Hey,
On Thu, 2024-01-18 at 11:49 +0100, Greg Kroah-Hartman wrote:
> 6.6-stable review patch. If anyone has any objections, please let me
> know.
Thanks for picking this up! To complete this fix the following is also
needed:
fca8a117c1c9 ("arm64: dts: armada-3720-turris-mox: set irq type for
RTC")
Not sure if i missed something causing this one to not be picked up,
while the others in the series were.
>
> ------------------
>
> From: Sjoerd Simons <sjoerd@xxxxxxxxxxxxx>
>
> commit e7830f5a83e96d8cb8efc0412902a03008f8fbe3 upstream.
>
> The Turris Mox shares the moxtet IRQ with various devices on the
> board,
> so mark the IRQ as shared in the driver as well.
>
> Without this loading the module will fail with:
> genirq: Flags mismatch irq 40. 00002002 (moxtet) vs. 00002080
> (mcp7940x)
>
> Signed-off-by: Sjoerd Simons <sjoerd@xxxxxxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # v6.2+
> Reviewed-by: Marek Behún <kabel@xxxxxxxxxx>
> Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/bus/moxtet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/bus/moxtet.c
> +++ b/drivers/bus/moxtet.c
> @@ -755,7 +755,7 @@ static int moxtet_irq_setup(struct moxte
> moxtet->irq.masked = ~0;
>
> ret = request_threaded_irq(moxtet->dev_irq, NULL,
> moxtet_irq_thread_fn,
> - IRQF_ONESHOT, "moxtet", moxtet);
> + IRQF_SHARED | IRQF_ONESHOT,
> "moxtet", moxtet);
> if (ret < 0)
> goto err_free;
>
>
>
--
Sjoerd Simons
Collabora Ltd.
