On Fri, 19 Jan 2024 at 12:08, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > @@ -577,6 +580,8 @@ static int ovl_dir_read_impure(const struct path *path, struct list_head *list, > > INIT_LIST_HEAD(list); > > *root = RB_ROOT; > > ovl_path_upper(path->dentry, &realpath); > > + if (ovl_path_check_xwhiteouts_xattr(ofs, &ofs->layers[0], &realpath)) > > + rdd.in_xwhiteouts_dir = true; > > Not needed since we do not support xwhiteouts on upper. Right. > > @@ -1079,6 +1090,8 @@ static int ovl_get_layers(struct super_block *sb, struct ovl_fs *ofs, > > l->name = NULL; > > ofs->numlayer++; > > ofs->fs[fsid].is_lower = true; > > + > > + > > extra spaces. Sorry, missing self review... > Do you want me to fix/test and send this to Linus? Yes please, if it's not a problem four you. Thanks, Miklos