On 17/01/2024 16:22, Mark Brown wrote: > On Wed, Jan 17, 2024 at 04:12:06PM +0100, Krzysztof Kozlowski wrote: > >> if (ret) { >> dev_err(dev, "%s: Fail to obtain platform data\n", __func__); >> - return -EINVAL; >> + return ret; > > Should this be a dev_err_probe() as well? It should be just dropped, which I do in the next patch. Errors are already printed in called wcd938x_populate_dt_data() (with dev_err_probe). However I decided to split them, as only this one is a candidate for backport, IMO. Feel free to squash the next (2/3) into this one. Best regards, Krzysztof