From: Stefan Wahren <wahrenst@xxxxxxx> [ Upstream commit 643fe70e7bcdcc9e2d96952f7fc2bab56385cce5 ] of_property_match_string returns an int; either an index from 0 or greater if successful or negative on failure. Even it's very unlikely that the DT CPU node contains multiple enable-methods these checks should be fixed. This patch was inspired by the work of Nick Desaulniers. Link: https://lore.kernel.org/lkml/20230516-sunxi-v1-1-ac4b9651a8c1@xxxxxxxxxx/T/ Cc: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> Signed-off-by: Stefan Wahren <wahrenst@xxxxxxx> Link: https://lore.kernel.org/r/20231228193903.9078-2-wahrenst@xxxxxxx Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> --- arch/arm/mach-sunxi/mc_smp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-sunxi/mc_smp.c b/arch/arm/mach-sunxi/mc_smp.c index ff173e67eed21..1fbc5b5a3cfe8 100644 --- a/arch/arm/mach-sunxi/mc_smp.c +++ b/arch/arm/mach-sunxi/mc_smp.c @@ -801,14 +801,14 @@ static int __init sunxi_mc_smp_init(void) for (i = 0; i < ARRAY_SIZE(sunxi_mc_smp_data); i++) { ret = of_property_match_string(node, "enable-method", sunxi_mc_smp_data[i].enable_method); - if (!ret) + if (ret >= 0) break; } is_a83t = sunxi_mc_smp_data[i].is_a83t; of_node_put(node); - if (ret) + if (ret < 0) return -ENODEV; if (!sunxi_mc_smp_cpu_table_init()) -- 2.43.0
