On Fri, Jan 05, 2024 at 09:16:42PM +0100, Petr Tesarik wrote:
> Fix per-queue statistics for devices with more than one queue.
>
> The output data pointer is currently reset in each loop iteration,
> effectively summing all queue statistics in the first four u64 values.
>
> The summary values are not even labeled correctly. For example, if eth0 has
> 2 queues, ethtool -S eth0 shows:
>
> q0_tx_pkt_n: 374 (actually tx_pkt_n over all queues)
> q0_tx_irq_n: 23 (actually tx_normal_irq_n over all queues)
> q1_tx_pkt_n: 462 (actually rx_pkt_n over all queues)
> q1_tx_irq_n: 446 (actually rx_normal_irq_n over all queues)
> q0_rx_pkt_n: 0
> q0_rx_irq_n: 0
> q1_rx_pkt_n: 0
> q1_rx_irq_n: 0
>
> Fixes: 133466c3bbe1 ("net: stmmac: use per-queue 64 bit statistics where necessary")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Petr Tesarik <petr@xxxxxxxxxxx>
Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
Andrew
