Sat, Jan 06, 2024 at 04:32:12AM CET, phil@xxxxxx wrote: >Hi, > >On Fri, Jan 05, 2024 at 12:59:24PM +0100, Jiri Pirko wrote: >> Thu, Jan 04, 2024 at 05:42:59PM CET, nicolas.dichtel@xxxxxxxxx wrote: >> >The below commit adds support for: >> >> ip link set dummy0 down >> >> ip link set dummy0 master bond0 up >> > >> >but breaks the opposite: >> >> ip link set dummy0 up >> >> ip link set dummy0 master bond0 down >> >> It is a bit weird to see these 2 and assume some ordering. >> The first one assumes: >> dummy0 master bond 0, dummy0 up >> The second one assumes: >> dummy0 down, dummy0 master bond 0 >> But why? >> >> What is the practival reason for a4abfa627c38 existence? I mean, >> bond/team bring up the device themselfs when needed. Phil? >> Wouldn't simple revert do better job here? > >Ah, I wasn't aware bond master manipulates slaves' links itself and thus >treated all types' link master setting the same by setting the slave up >afterwards. This is basically what a4abfa627c38 is good for: Enabling >'ip link set X master Y up' regardless of Y's link type. > >If setting a bond slave up manually is not recommended, the easiest >solution is probbaly indeed to revert a4abfa627c38 and live with the >quirk in bond driver. Okay, lets revert then. > >Cheers, Phil
