On Sun, Dec 31, 2023 at 04:49:08PM +0100, Sven Joachim wrote:
> On 2023-12-30 12:00 +0000, Greg Kroah-Hartman wrote:
>
> > 6.1-stable review patch. If anyone has any objections, please let me know.
>
> This failed to build here:
>
> ,----
> | CC [M] drivers/block/loop.o
> | drivers/block/loop.c: In function 'loop_probe':
> | drivers/block/loop.c:2125:6: error: 'max_loop_specified' undeclared (first use in this function)
> | 2125 | if (max_loop_specified && max_loop && idx >= max_loop)
> | | ^~~~~~~~~~~~~~~~~~
> | drivers/block/loop.c:2125:6: note: each undeclared identifier is reported only once for each function it appears in
> | make[6]: *** [scripts/Makefile.build:250: drivers/block/loop.o] Error 1
> `----
>
> > @@ -2093,7 +2122,7 @@ static void loop_probe(dev_t dev)
> > {
> > int idx = MINOR(dev) >> part_shift;
> >
> > - if (max_loop && idx >= max_loop)
> > + if (max_loop_specified && max_loop && idx >= max_loop)
> > return;
> > loop_add(idx);
> > }
>
> If CONFIG_BLOCK_LEGACY_AUTOLOAD is not set, max_loop_specified is
> undeclared. Applying commit 23881aec85f3 ("loop: deprecate autoloading
> callback loop_probe()") fixes that.
Thanks, now queued up.
greg k-h
