2023-12-19 2:56 GMT+09:00, Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>:
> Hi,
Hi Christophe,
>
> unless explicitly needed because of other patches that rely on it,
> patches 03, 28 and 42 / 154 don't look as good candidate for backport.
Even if there is no problem now, a hunk failure may occur later when
the new change near these patches is applied. So I decided to apply
clean-up patches as well.
Thanks.
>
> CJ
>
>
> Le 18/12/2023 à 16:32, Namjae Jeon a écrit :
>> From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
>>
>> [ Upstream commit e8d585b2f68c0b10c966ee55146de043429085a3 ]
>>
>> 'destroy_workqueue()' already drains the queue before destroying it, so
>> there is no need to flush it explicitly.
>>
>> Remove the redundant 'flush_workqueue()' calls.
>>
>> This was generated with coccinelle:
>>
>> @@
>> expression E;
>> @@
>> - flush_workqueue(E);
>> destroy_workqueue(E);
>>
>> Acked-by: Namjae Jeon <linkinjeon@xxxxxxxxxx>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
>> Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>
>> ---
>> fs/ksmbd/ksmbd_work.c | 1 -
>> fs/ksmbd/transport_rdma.c | 1 -
>> 2 files changed, 2 deletions(-)
>>
>> diff --git a/fs/ksmbd/ksmbd_work.c b/fs/ksmbd/ksmbd_work.c
>> index fd58eb4809f6..14b9caebf7a4 100644
>> --- a/fs/ksmbd/ksmbd_work.c
>> +++ b/fs/ksmbd/ksmbd_work.c
>> @@ -69,7 +69,6 @@ int ksmbd_workqueue_init(void)
>>
>> void ksmbd_workqueue_destroy(void)
>> {
>> - flush_workqueue(ksmbd_wq);
>> destroy_workqueue(ksmbd_wq);
>> ksmbd_wq = NULL;
>> }
>> diff --git a/fs/ksmbd/transport_rdma.c b/fs/ksmbd/transport_rdma.c
>> index 9ca29cdb7898..86446742f4ad 100644
>> --- a/fs/ksmbd/transport_rdma.c
>> +++ b/fs/ksmbd/transport_rdma.c
>> @@ -2049,7 +2049,6 @@ int ksmbd_rdma_destroy(void)
>> smb_direct_listener.cm_id = NULL;
>>
>> if (smb_direct_wq) {
>> - flush_workqueue(smb_direct_wq);
>> destroy_workqueue(smb_direct_wq);
>> smb_direct_wq = NULL;
>> }
>
