On Wed, Dec 06, 2023 at 11:49:46AM +0300, kovalev@xxxxxxxxxxxx wrote: > From: Vasiliy Kovalev <kovalev@xxxxxxxxxxxx> > > This reverts commit 5a46dc8e4a064769e916d87bf9bccae75afc7289. > > Commit 50b6f2c8297793f7f3315623db78dcff85158e96 upstream. > > Commit 5a46dc8e4a0647 ("drm/edid: Fix csync detailed mode parsing") fixed > EDID detailed mode sync parsing. Unfortunately, there are quite a few > displays out there that have bogus (zero) sync field that are broken by > the change. Zero means analog composite sync, which is not right for > digital displays, and the modes get rejected. Regardless, it used to > work, and it needs to continue to work. Revert the change. > > Rejecting modes with analog composite sync was the part that fixed the > gitlab issue 8146 [1]. We'll need to get back to the drawing board with > that. > > [1] https://gitlab.freedesktop.org/drm/intel/-/issues/8146 > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8789 > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8930 > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9044 > Fixes: 5a46dc8e4a0647 ("drm/edid: Fix csync detailed mode parsing") > Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > Cc: <stable@xxxxxxxxxxxxxxx> # v6.4+ > Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> > Acked-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Link: https://patchwork.freedesktop.org/patch/msgid/20230815101907.2900768-1-jani.nikula@xxxxxxxxx > Signed-off-by: Vasiliy Kovalev <kovalev@xxxxxxxxxxxx> > --- > drivers/gpu/drm/drm_edid.c | 26 +++++++------------------- > include/drm/drm_edid.h | 12 +++--------- > 2 files changed, 10 insertions(+), 28 deletions(-) You sent this 3 times, why? And what tree is this backport for? It's already in the respective stable releases, right? confused, greg k-h