Re: Patch "spi: imx: add a device specific prepare_message callback" has been added to the 4.19-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Fri, Dec 08, 2023 at 05:08:32AM -0500, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
> 
>     spi: imx: add a device specific prepare_message callback
> 
> to the 4.19-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      spi-imx-add-a-device-specific-prepare_message-callba.patch
> and it can be found in the queue-4.19 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@xxxxxxxxxxxxxxx> know about it.
> 
> 
> 
> commit b19a3770ce84da3c16acc7142e754cd8ff80ad3d
> Author: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Date:   Fri Nov 30 07:47:05 2018 +0100
> 
>     spi: imx: add a device specific prepare_message callback
>     
>     [ Upstream commit e697271c4e2987b333148e16a2eb8b5b924fd40a ]
>     
>     This is just preparatory work which allows to move some initialisation
>     that currently is done in the per transfer hook .config to an earlier
>     point in time in the next few patches. There is no change in behaviour
>     introduced by this patch.
>     
>     Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>     Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
>     Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

The patch alone shouldn't be needed for stable and there is no
indication that it's a dependency for another patch. Is this an
oversight?

Other than that: IMHO the subject for this type of report could be improved. Currently it's:

	Subject: Patch "spi: imx: add a device specific prepare_message callback" has been added to the 4.19-stable tree

The most important part of it is "4.19-stable", but that only appears
after character column 90 and so my MUA doesn't show it unless the
window is wider than my default setting. Maybe make this:

	Subject: for-stable-4.19: "spi: imx: add a device specific prepare_message callback"

?

Another thing I wonder about is: The mail contains

	If you, or anyone else, feels it should not be added to the
	stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it.

but it wasn't sent to stable@xxxxxxxxxxxxxxx.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux