On Thu, Dec 07, 2023 at 02:00:06AM +0300, Alexey Khoroshilov wrote: > On 05.12.2023 22:22, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.10.203 release. > > There are 131 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000. > > Anything received after that time might be too late. > > > > The whole patch series can be found in one patch at: > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.203-rc3.gz > > or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y > > and the diffstat can be found below. > > > > thanks, > > > > greg k-h > > > It seems something is seriously broken in this release. > > There are patches already applied in 5.10.202 that are in 5.10.203-rc3 > transformed in some strange way, e.g. > > Neil Armstrong <narmstrong@xxxxxxxxxxxx> > tty: serial: meson: retrieve port FIFO size from DT > > > commit 980c3135f1ae6fe686a70c8ba78eb1bb4bde3060 in 5.10.202 > > diff --git a/drivers/tty/serial/meson_uart.c > b/drivers/tty/serial/meson_uart.c > index d06653493f0e..78bda91a6bf1 100644 > --- a/drivers/tty/serial/meson_uart.c > +++ b/drivers/tty/serial/meson_uart.c > @@ -728,6 +728,7 @@ static int meson_uart_probe(struct platform_device > *pdev) > { > struct resource *res_mem, *res_irq; > struct uart_port *port; > + u32 fifosize = 64; /* Default is 64, 128 for EE UART_0 */ > int ret = 0; > > if (pdev->dev.of_node) > @@ -755,6 +756,8 @@ static int meson_uart_probe(struct platform_device > *pdev) > if (!res_irq) > return -ENODEV; > > + of_property_read_u32(pdev->dev.of_node, "fifo-size", &fifosize); > + > if (meson_ports[pdev->id]) { > dev_err(&pdev->dev, "port %d already allocated\n", > pdev->id); > return -EBUSY; > @@ -784,7 +787,7 @@ static int meson_uart_probe(struct platform_device > *pdev) > port->type = PORT_MESON; > port->x_char = 0; > port->ops = &meson_uart_ops; > - port->fifosize = 64; > + port->fifosize = fifosize; > > meson_ports[pdev->id] = port; > platform_set_drvdata(pdev, port); > > vs. > > commit 71feab929585232694b4f2fb7d70abde4edc581e in 5.10.203-rc3 > > diff --git a/drivers/tty/serial/meson_uart.c > b/drivers/tty/serial/meson_uart.c > index bb66a3f06626..c44ab21a9b7d 100644 > --- a/drivers/tty/serial/meson_uart.c > +++ b/drivers/tty/serial/meson_uart.c > @@ -765,6 +765,8 @@ static int meson_uart_probe(struct platform_device > *pdev) > of_property_read_u32(pdev->dev.of_node, "fifo-size", &fifosize); > has_rtscts = of_property_read_bool(pdev->dev.of_node, > "uart-has-rtscts"); > > + of_property_read_u32(pdev->dev.of_node, "fifo-size", &fifosize); > + > if (meson_ports[pdev->id]) { > dev_err(&pdev->dev, "port %d already allocated\n", > pdev->id); > return -EBUSY; > > > > Found by Linux Verification Center (linuxtesting.org) with SVACE > > > > See also: > > Qu Huang <qu.huang@xxxxxxxxx> > drm/amdgpu: Fix a null pointer access when the smc_rreg pointer is NULL > > Axel Lin <axel.lin@xxxxxxxxxx> > i2c: sun6i-p2wi: Prevent potential division by zero > > Takashi Iwai <tiwai@xxxxxxx> > media: imon: fix access to invalid resource for the second interface > > > Also there is a strange pair: > > Patrick Thompson <ptf@xxxxxxxxxx> > net: r8169: Disable multicast filter for RTL8168H and RTL8107E > > Heiner Kallweit <hkallweit1@xxxxxxxxx> > Revert "net: r8169: Disable multicast filter for RTL8168H and RTL8107E" > Ok, I dropped all of these and manually verified that there were no other duplicates. thanks for catching them and letting us know. greg k-h
