On Wed, 2023-12-06 at 14:13 +0100, Rouven Czerwinski wrote: > > +++ b/net/rfkill/rfkill-gpio.c > @@ -126,6 +126,16 @@ static int rfkill_gpio_probe(struct platform_device *pdev) > return -EINVAL; > } > > + if (rfkill->reset_gpio) > + ret = gpiod_direction_output(rfkill->reset_gpio, true); > + if (ret) > + return ret; > + > + if (rfkill->shutdown_gpio) > + ret = gpiod_direction_output(rfkill->shutdown_gpio, true); > + if (ret) > + return ret; > That's weird, you need ret to be inside the if. It's even entirely uninitialized if you don't have ACPI, if you don't have reset/shutdown. johannes
