Re: [PATCH 1/4] xhci: don't start a halted endpoint before its new dequeue is set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14.11.2014 19:29, Felipe Balbi wrote:
> On Fri, Nov 14, 2014 at 07:23:49PM +0200, Mathias Nyman wrote:
>> A halted endpoint ring must first be reset, then move the ring
>> dequeue pointer past the problematic TRB. If we start the ring too
>> early after reset, but before moving the dequeue pointer we
>> will end up executing the same problematic TRB again.
>>
>> As we always issue a set transfer dequeue command after a reset
>> endpoint command we can skip starting endpoint rings at reset endpoint
>> command completion.
>>
>> Without this fix we end up trying to handle the same faulty TD for
>> contol endpoints. causing timeout, and failing testusb ctrl_out write
>> tests.
>>
>> Fixes: bcef3fd (USB: xhci: Handle errors that cause endpoint halts.)
>> Cc: <stable@xxxxxxxxxxxxxxx> # v2.6.33+
> 
> this one is something else, here you go:
> 
> Fixes: e9df17e (USB: xhci: Correct assumptions about number of rings per endpoint.)
> Cc: <stable@xxxxxxxxxxxxxxx> #v2.6.35
> 

ah, ok, I'll resend

-Mathias

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]