Re: [PATCH 6.5 153/191] Input: xpad - add HyperX Clutch Gladiate Support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 22, 2023 at 03:10:39PM -0800, Nguyen, Max wrote:
> 
> On 11/22/2023 2:18 PM, Nguyen, Max wrote:
> > 
> > On 11/21/2023 10:39 PM, Greg KH wrote:
> > > On Tue, Nov 21, 2023 at 04:17:54PM -0800, Nguyen, Max wrote:
> > > > On 11/20/2023 3:52 PM, Nguyen, Max wrote:
> > > > > On 11/18/2023 3:32 AM, Greg KH wrote:
> > > > > > On Fri, Nov 17, 2023 at 03:42:22PM -0800, Nguyen, Max wrote:
> > > > > > > > Hi,
> > > > > > > > 
> > > > > > > > We would like to apply this patch to version 6.1 of the LTS branch.
> > > > > > > > This is to add a project ID for Android support for a gamepad
> > > > > > > > controller.  We would like it to apply sooner than waiting
> > > > > > > > for the next
> > > > > > > > LTS branch due to project schedules.
> > > > > > > > 
> > > > > > > > commite28a0974d749e5105d77233c0a84d35c37da047e
> > > > > > > > 
> > > > > > > > Regards,
> > > > > > > > 
> > > > > > > > Max
> > > > > > > > 
> > > > > > > Hi Linux team,
> > > > > > > 
> > > > > > > We would like to have this patch backported to LTS versions
> > > > > > > 4.19, 5.4, 5.10,
> > > > > > > and 5.15 as well.  The main purpose would to add our device ID
> > > > > > > for support
> > > > > > > across older android devices.  Feel free to let us know if there
> > > > > > > are any
> > > > > > > concerns or issues.
> > > > > > Please provide a working backport that you have tested
> > > > > > as I think it did
> > > > > > not apply cleanly on its own, right?
> > > > > > 
> > > > > > thanks,
> > > > > > 
> > > > > > greg k-h
> > > > > Hi Greg,
> > > > > 
> > > > > Do you have any general suggestions or instructions on how I
> > > > > can create
> > > > > a backport to test?  I apologize as this is new to me.
> > > > > 
> > > > > Also, what do you mean by the patch did not apply cleanly on its own?
> > > > > 
> > > > We found that the patch does not apply correctly to the previous LTS
> > > > kernels.  This is most likely due to addition of newer devices
> > > > over time.
> > > > We will be sending separate patches for each kernel shortly.
> > > Why not send a series adding all of the missing backported patches?
> > > That makes it better so that all of the supported devices are now
> > > working on the older kernels, not just this one.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > Hi Greg,
> > 
> > I am planning to send a patch for LTS versions 4.19 through 5.15 since
> > the single patch can apply to all of these versions with no issues.  I
> > plan to send a separate patch for LTS 6.1 since this patch could not
> > apply to the older LTS versions.
> > 
> > Is this what you had in mind when you mentioned series?
> > 
> I resent the patches as a series as described in the patch submission
> process on the kernel webpage.  I reviewed and believe it should be
> formatted correctly now.  Let me know if there are any issues.

No, I mean, for each stable kernel version/tree/whatever, send a patch
series that adds all of the missing ids to the table, not just your one
specific device you are asking for here.  That way the trees are all in
sync proper AND any future patches will also apply cleanly/properly to
the older kernel versions.

Does that help?

thanks,

greg k-h




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux