On Wed, Nov 22, 2023 at 04:35:17PM +0000, Greg Kroah-Hartman wrote:
> On Wed, Nov 22, 2023 at 04:41:37PM +0100, Johan Hovold wrote:
> > Hi Greg and Sasha,
> >
> > On Fri, Oct 27, 2023 at 01:52:11PM +0200, Johan Hovold wrote:
> > > On Fri, Oct 27, 2023 at 11:57:45AM +0100, Srinivas Kandagatla wrote:
> > > > Click/Pop Noise was a long pending issue with WSA Codecs which are prone
> > > > to accumlate DC when ports are active but without any data streams.
> > > > There are multiple places in the current setup, where this could happen
> > > > in both startup as well as shutdown path.
> > > >
> > > > This patchset adds a new flag mute_unmute_on_trigger to dai_ops to let
> > > > generic code do the mute/unmute on trigger.
> > > >
> > > > This patches help fix those issues by making sure the PA is Muted/Unmuted
> > > > inline with the stream start/stop events.
> > > >
> > > > Srinivas Kandagatla (2):
> > > > ASoC: soc-dai: add flag to mute and unmute stream during trigger
> > > > ASoC: codecs: wsa883x: make use of new mute_unmute_on_trigger flag
> > >
> > > I've verified that this fixes the pop sounds when starting and stopping
> > > a stream on the X13s, even if the click sound when killing pulseaudio
> > > (e.g. on reboot) is still there (as with the previous fixes).
> > >
> > > Tested-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> > >
> > > If these are accepted, can we get them backported to 6.5 as well?
> >
> > These fixes are now in 6.7-rc1 as
> >
> > f0220575e65a ("ASoC: soc-dai: add flag to mute and unmute stream during trigger")
>
> This doesn't backport cleanly, can you provide a working backport?
>
> > 805ce81826c8 ("ASoC: codecs: wsa883x: make use of new mute_unmute_on_trigger flag")
>
> Now queued up, thanks.
And that broke the build, I'll go drop that too :(
