Re: [PATCH] pinctrl: avoid reload of p state in interation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/14/2023 9:21 PM, Linus Walleij wrote:
Hi Maria,

thanks for your patch!

On Tue, Nov 14, 2023 at 9:54 AM Maria Yu <quic_aiquny@xxxxxxxxxxx> wrote:

When in the list_for_each_entry interation, reload of p->state->settings
with a local setting from old_state will makes the list interation in a
infite loop.

Signed-off-by: Maria Yu <quic_aiquny@xxxxxxxxxxx>

This makes sense in a way, since this is a compiler-dependent problem,
can you state in the commit message which compiler and architecture
you see this on?
I have a crash dump which caused by this issue which is using Clang 10.0, arm64, Linux Version 4.19.
Thx for your suggestion, I will put this information in the commit message.

If it is a regression, should this also be queued for stable? (I guess so?)
This is a corner case which is very hard to reproduce in product, I suggest this fix to be queued for stable.

Yours,
Linus Walleij

--
Thx and BRs,
Aiqun(Maria) Yu




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux