Re: [PATCH v2 1/1] lib/vsprintf: Fix %pfwf when current node refcount == 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andy,

On Tue, 14 Nov 2023 16:59:35 +0200
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

[...]

> 
> One nit-pick below, otherwise
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> 
> ...
> 
> >  	/* Loop starting from the root node to the current node. */
> >  	for (depth = fwnode_count_parents(fwnode); depth >= 0; depth--) {
> > -		struct fwnode_handle *__fwnode =
> > -			fwnode_get_nth_parent(fwnode, depth);
> > +		/*
> > +		 * Only get a reference for other nodes (ie parents node).  
> 
> "parent's node" (doesn't look right)? Or "parent nodes"?
> 

Will be changed to "parent nodes" in the next iteration.

Best regards,
Hervé



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux