On Tue, Nov 14, 2023 at 03:27:43PM +0200, Andy Shevchenko wrote: > On Tue, Nov 14, 2023 at 02:19:34PM +0100, Herve Codina wrote: > > On Tue, 14 Nov 2023 15:12:47 +0200 > > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > On Tue, Nov 14, 2023 at 12:04:56PM +0100, Herve Codina wrote: > > > > A refcount issue can appeared in __fwnode_link_del() due to the > > > > pr_debug() call: ---8<--- > > > > WARNING: CPU: 0 PID: 901 at lib/refcount.c:25 refcount_warn_saturate+0xe5/0x110 > > > > Call Trace: > > > > ? refcount_warn_saturate+0xe5/0x110 > > ... These are actually not needed as duplicating WARNING above. > > > > of_node_get+0x1e/0x30 > > > > of_fwnode_get+0x28/0x40 > > > > fwnode_full_name_string+0x34/0x90 > > > > fwnode_string+0xdb/0x140 > ... > > > > > vsnprintf+0x17b/0x630 > ... > > > > __fwnode_link_del+0x25/0xa0 > > > > fwnode_links_purge+0x39/0xb0 > > > > of_node_release+0xd9/0x180 > ... ---8<--- > > > Please, do not put so many unrelated lines of backtrace in the commit message. > > > Leave only the important ones (the Submitting Patches document suggests some > > > like ~3-5 lines only). > > > > Ok, I will remove some of them. > > Thanks (my suggestion is above). -- With Best Regards, Andy Shevchenko
