Hi Mark, Ilpo, On 10/30/2023 9:39 PM, Mark Hasemeyer wrote: >> Hi, >> >> Thank you for your patch. This has already come up but no acceptable patch >> has emerged since. Please see this thread for what needs to be done if you >> want to provide one (or maybe Shyam already has one which has just not >> been sent out yet): Yes. Was talking to FW team before I respin. >> >> https://lore.kernel.org/platform-driver-x86/3b224c62-a1d8-41bd-aced-5825f5f20e66@xxxxxxx/ >> >> (Since this dram size is on an init path that always needs SMU version, >> the SMU version can just be called by the init unconditonally rather than >> adding more of this lazy initialization everywhere). > > Thanks for pointing me to that thread. I think Shyam/AMD can come up > with a better long term solution, but it may be worth pushing this > patch through for a couple reasons: > 1. Probing of the driver currently fails on STB enabled systems with a > Mendocino SoC. A slower boot time is better than the driver failing to > load IMO. > 2. This patch only affects Mendocino SoCs, and was a suggested > solution from Mario in the thread you mentioned. > I have a patch in place that should address the problem you are mentioning. I will send that out next Monday after some tests. Thanks, Shyam > That said, I can also just disable STB for now...
