Re: [PATCH 4.19 06/98] platform/x86: hp-wmi:: Mark driver struct with __refdata to prevent section mismatch warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 23, 2023 at 06:40:57PM +0200, Uwe Kleine-König wrote:
> On Mon, Oct 23, 2023 at 12:55:55PM +0200, Greg Kroah-Hartman wrote:
> > 4.19-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > 
> > [ Upstream commit 5b44abbc39ca15df80d0da4756078c98c831090f ]
> > 
> > As described in the added code comment, a reference to .exit.text is ok
> > for drivers registered via module_platform_driver_probe(). Make this
> > explicit to prevent a section mismatch warning:
> > 
> > 	WARNING: modpost: drivers/platform/x86/hp/hp-wmi: section mismatch in reference: hp_wmi_driver+0x8 (section: .data) -> hp_wmi_bios_remove (section: .exit.text)
> 
> While that __ref is actually missing since the blamed commit, modpost
> only warns about .data -> .exit.text mismatches since
> 
> 	f177cd0c15fc ("modpost: Don't let "driver"s reference .exit.*")
> 
> (currently in next). So if your goal is to silence warnings in stable,
> patches of this type don't need to be backported unless f177cd0c15fc is
> backported, too. (But they don't hurt either.)

I'll go drop them, thanks!

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux