On Mon, Oct 23, 2023 at 10:39:03AM +0100, Lee Jones wrote: > On Mon, 23 Oct 2023, Greg Kroah-Hartman wrote: > > > On Wed, Oct 18, 2023 at 01:04:34PM +0100, Lee Jones wrote: > > > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > > > > > commit 42cd402b8fd4672b692400fe5f9eecd55d2794ac upstream. > > > > > > The driver_override field from platform driver should not be initialized > > > from static memory (string literal) because the core later kfree() it, > > > for example when driver_override is set via sysfs. > > > > > > Use dedicated helper to set driver_override properly. > > > > > > Fixes: 950a7388f02b ("rpmsg: Turn name service into a stand alone driver") > > > Fixes: c0cdc19f84a4 ("rpmsg: Driver for user space endpoint interface") > > > Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > > Link: https://lore.kernel.org/r/20220419113435.246203-13-krzysztof.kozlowski@xxxxxxxxxx > > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > Signed-off-by: Lee Jones <lee@xxxxxxxxxx> > > > --- > > > drivers/rpmsg/rpmsg_internal.h | 13 +++++++++++-- > > > include/linux/rpmsg.h | 6 ++++-- > > > 2 files changed, 15 insertions(+), 4 deletions(-) > > > > Any specific reason why you missed the fixes for this commit as well? > > Turned out to need some more things after this :( > > No reason not to. I didn't notice them. fixes for fixes are important :) > Which patches have you dropped? Just these 3 or all branches? All branches. thanks, greg k-h