Re: [PATCH v1] ALSA: SOF: sof-pci-dev: Fix community key quirk detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Curtis Malainey | Chrome OS Audio Senior Software Engineer |
cujomalainey@xxxxxxxxxx | Sound Open Firmware Lead


On Fri, Oct 20, 2023 at 2:00 PM Mark Hasemeyer <markhas@xxxxxxxxxxxx> wrote:
>
> Some Chromebooks do not populate the product family DMI value resulting
> in firmware load failures.
>
> Add another quirk detection entry that looks for "Google" in the BIOS
> version. Theoretically, PRODUCT_FAMILY could be replaced with
> BIOS_VERSION, but it is left as a quirk to be conservative.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Mark Hasemeyer <markhas@xxxxxxxxxxxx>

Acked-by: Curtis Malainey <cujomalainey@xxxxxxxxxxxx>

> ---
>
>  sound/soc/sof/sof-pci-dev.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/sound/soc/sof/sof-pci-dev.c b/sound/soc/sof/sof-pci-dev.c
> index 1d706490588e..64b326e3ef85 100644
> --- a/sound/soc/sof/sof-pci-dev.c
> +++ b/sound/soc/sof/sof-pci-dev.c
> @@ -145,6 +145,13 @@ static const struct dmi_system_id community_key_platforms[] = {
>                         DMI_MATCH(DMI_PRODUCT_FAMILY, "Google"),
>                 }
>         },
> +       {
> +               .ident = "Google firmware",
> +               .callback = chromebook_use_community_key,
> +               .matches = {
> +                       DMI_MATCH(DMI_BIOS_VERSION, "Google"),
> +               }
> +       },
>         {},
>  };
>
> --
> 2.42.0.655.g421f12c284-goog
>




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux