On Thu, Oct 19, 2023 at 09:28:59AM -0700, Jakub Kicinski wrote: > On Mon, 16 Oct 2023 10:41:07 +0200 Greg Kroah-Hartman wrote: > > A bitset without mask in a _SET request means we want exactly the bits in > > the bitset to be set. This works correctly for compact format but when > > verbose format is parsed, ethnl_update_bitset32_verbose() only sets the > > bits present in the request bitset but does not clear the rest. The commit > > 6699170376ab fixes this issue by clearing the whole target bitmap before we > > start iterating. The solution proposed brought an issue with the behavior > > of the mod variable. As the bitset is always cleared the old val will > > always differ to the new val. > > > > Fix it by adding a new temporary variable which save the state of the old > > bitmap. > > This one got reverted / needs more work. > Please drop across the branches. Now dropped, thanks. greg k-h
