Re: [PATCH 5.15 000/102] 5.15.136-rc1 review

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

On 16/10/23 10:28 pm, Greg Kroah-Hartman wrote:
On Mon, Oct 16, 2023 at 09:23:36PM +0530, Harshit Mogalapalli wrote:
Hi Greg,

On 16/10/23 8:44 pm, Greg Kroah-Hartman wrote:
On Mon, Oct 16, 2023 at 07:06:20PM +0530, Harshit Mogalapalli wrote:
Hi Greg,

On 16/10/23 2:09 pm, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 5.15.136 release.
There are 102 patches in this series, all will be posted as a response
to this one.  If anyone has any issues with these being applied, please
let me know.

Responses should be made by Wed, 18 Oct 2023 08:39:38 +0000.
Anything received after that time might be too late.


I am seeing a build failure while compiling tools/perf/

In file included from tests/genelf.c:14:
tests/../util/genelf.h:5:10: fatal error: linux/math.h: No such file or
directory
   5 | #include <linux/math.h>
   | ^~~~~~~~~~~~~~
compilation terminated.

Patch 43 in this series is causing this.


Sorry for the confusion.

What is patch 43?

It is patch 42/102 in this series

https://lore.kernel.org/stable/2023101641-resource-scalding-3e1d@gregkh/T/#m70a2a03b6204085af187184af911570681e744f5

Commit: e2bf685d7e311 ("perf inject: Fix GEN_ELF_TEXT_OFFSET for jit")



Why is this not reproducible upstream ?

Vegard bisected the commit which makes it not reproducible upstream and this
commit is missing in 5.15.y:
Commit: d6e6a27d960f ("tools: Fix math.h breakage")

Backport request for this was made here:
https://lore.kernel.org/all/CAMVNhxS-6qNfxy8jHrY5EtZASTL9gAvZi=BdTkUA5_5CSQ2Cmg@xxxxxxxxxxxxxx/

And that commit is in this patch series, so are you sure that was
correct?


Cause for this build issue:
Commit: e2bf685d7e311 ("perf inject: Fix GEN_ELF_TEXT_OFFSET for jit")

And this issue is not in upstream due to presence of commit d6e6a27d960f
("tools: Fix math.h breakage") in upstream but not in 5.15.y

Ok, I'll go drop the patch entirely, I can't even get perf to build at
all for me on 5.15, which is why I've given up on it even mattering
anymore :(

Thanks,

After reverting this patch locally, no problems seen on x86_64 and aarch64 for this rc.

Tested-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>

Regards,
Harshit


thanks,

greg k-h




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux