USB_NET_AX8817X dependency on AX88796B_PHY

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I've received reports that an ethernet usb dongle doesn't work (google
internal bug 304028301)...

Investigation shows that we have 5.10 (GKI) with USB_NET_AX8817X=y and
AX88796B_PHY not set.
I *think* this configuration combination makes no sense?
[note: I'm unsure how many different phy's this driver supports...]

Obviously, we could simply turn it on 'manually'... but:

commit dde25846925765a88df8964080098174495c1f10
Author: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
Date:   Mon Jun 7 10:27:22 2021 +0200

    net: usb/phy: asix: add support for ax88772A/C PHYs

    Add support for build-in x88772A/C PHYs

    Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
    Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

includes (as a side effect):

drivers/net/usb/Kconfig
@@ -164,6 +164,7 @@ config USB_NET_AX8817X
        depends on USB_USBNET
        select CRC32
        select PHYLIB
+       select AX88796B_PHY
        default y

which presumably makes this (particular problem) a non issue on 5.15+

I'm guessing the above fix (ie. commit dde25846925765a88df8964080098174495c1f10)
could (should?) simply be backported to older stable kernels?

I've verified it cherrypicks cleanly and builds (on x86_64 5.10 gki),
ie.
$ git checkout android/kernel/common/android13-5.10
$ git cherry-pick -x dde25846925765a88df8964080098174495c1f10
$ make ARCH=x86_64 gki_defconfig
$ egrep -i ax88796b < .config
CONFIG_AX88796B_PHY=y
$ make -j50
./drivers/net/phy/ax88796b.o gets built

I've sourced a copy of the problematic hardware, but I'm hitting
problems where on at least two (both my chromebook and 1 of the 2
usb-c ports on my lenovo laptop) totally different usb
controllers/ports it doesn't even usb enumerate (ie. nothing in dmesg,
no show on lsusb), which is making testing difficult (unsure if I just
got a bad sample)...

- Maciej



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux