On Mon, Oct 09, 2023 at 04:29:38PM +0200, Takashi Iwai wrote:
On Mon, 09 Oct 2023 16:25:13 +0200,
Sasha Levin wrote:
On Mon, Oct 09, 2023 at 03:17:59PM +0200, Takashi Iwai wrote:
> On Mon, 09 Oct 2023 14:59:25 +0200,
> Greg Kroah-Hartman wrote:
>>
>> 6.5-stable review patch. If anyone has any objections, please let me know.
>>
>> ------------------
>>
>> From: Shenghao Ding <shenghao-ding@xxxxxx>
>>
>> [ Upstream commit 3babae915f4c15d76a5134e55806a1c1588e2865 ]
>>
>> Integrate tas2781 configs for Lenovo Laptops. All of the tas2781s in the
>> laptop will be aggregated as one audio device. The code support realtek
>> as the primary codec. Rename "struct cs35l41_dev_name" to
>> "struct scodec_dev_name" for all other side codecs instead of the certain
>> one.
>>
>> Signed-off-by: Shenghao Ding <shenghao-ding@xxxxxx>
>> Link: https://lore.kernel.org/r/20230818085836.1442-1-shenghao-ding@xxxxxx
>> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
>> Stable-dep-of: 41b07476da38 ("ALSA: hda/realtek - ALC287 Realtek I2S speaker platform support")
>> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
>
> This makes little sense without the backport of commit
> 5be27f1e3ec9 ("ALSA: hda/tas2781: Add tas2781 HDA driver").
> Confusingly, the patch subject is very same as this commit...
This is a tricky one: 3babae915f4 really doesn't add a new driver but
rather just refactors some of the quirk handling which is needed for
later patches to apply. It's the following 5be27f1e3ec9 which actually
adds the driver (which we don't need here).
We don't actually want to bring in a new driver, so 5be27f1e3ec9 is
unnecessary.
If we don't want the backport of 5be27f1e3ec9, this commit
(3babae915f4c) and other relevant ones must be dropped, too.
Sure, I've dropped:
3babae915f4c ("ALSA: hda/tas2781: Add tas2781 HDA driver")
93dc18e11b1a ("ALSA: hda/realtek: Add quirk for HP Victus 16-d1xxx to enable mute LED")
c99c26b16c15 ("ALSA: hda/realtek: Add quirk for mute LEDs on HP ENVY x360 15-eu0xxx")
e43252db7e20 ("ALSA: hda/realtek - ALC287 I2S speaker platform support")
41b07476da38 ("ALSA: hda/realtek - ALC287 Realtek I2S speaker platform support")
--
Thanks,
Sasha
