> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of Jesse Brandeburg > Sent: Tuesday, October 3, 2023 11:01 AM > To: intel-wired-lan@xxxxxxxxxxxxxxxx > Cc: netdev@xxxxxxxxxxxxxxx; Brandeburg, Jesse <jesse.brandeburg@xxxxxxxxx>; stable@xxxxxxxxxxxxxxx; Kitszel, Przemyslaw <przemyslaw.kitszel@xxxxxxxxx> > Subject: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix over-shifted variable > > Since the introduction of the ice driver the code has been > double-shifting the RSS enabling field, because the define already has > shifts in it and can't have the regular pattern of "a << shiftval & > mask" applied. > > Most places in the code got it right, but one line was still wrong. Fix > this one location for easy backports to stable. An in-progress patch > fixes the defines to "standard" and will be applied as part of the > regular -next process sometime after this one. > > Fixes: d76a60ba7afb ("ice: Add support for VLANs and offloads") > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx> > CC: stable@xxxxxxxxxxxxxxx > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx> > --- > drivers/net/ethernet/intel/ice/ice_lib.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@xxxxxxxxx> (A Contingent worker at Intel)