On Wed, Sep 20, 2023 at 10:33:31AM -0500, Mario Limonciello wrote:
> From: Wayne Lin <wayne.lin@xxxxxxx>
>
> [Why]
> In drm_dp_mst_topology_mgr_resume() today, it will resume the
> mst branch to be ready handling mst mode and also consecutively do
> the mst topology probing. Which will cause the dirver have chance
> to fire hotplug event before restoring the old state. Then Userspace
> will react to the hotplug event based on a wrong state.
>
> [How]
> Adjust the mst resume flow as:
> 1. set dpcd to resume mst branch status
> 2. restore source old state
> 3. Do mst resume topology probing
>
> For drm_dp_mst_topology_mgr_resume(), it's better to adjust it to
> pull out topology probing work into a 2nd part procedure of the mst
> resume. Will have a follow up patch in drm.
>
> Reviewed-by: Chao-kai Wang <stylon.wang@xxxxxxx>
> Cc: Mario Limonciello <mario.limonciello@xxxxxxx>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Acked-by: Stylon Wang <stylon.wang@xxxxxxx>
> Signed-off-by: Wayne Lin <wayne.lin@xxxxxxx>
> Tested-by: Daniel Wheeler <daniel.wheeler@xxxxxxx>
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> (cherry picked from commit ec5fa9fcdeca69edf7dab5ca3b2e0ceb1c08fe9a)
> Adjust for missing variable rename in
> f0127cb11299 ("drm/amdgpu/display/mst: adjust the naming of mst_port and port of aconnector")
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> ---
> This is a follow up for https://lore.kernel.org/stable/2023092029-banter-truth-cf72@gregkh/
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 93 ++++++++++++++++---
> 1 file changed, 80 insertions(+), 13 deletions(-)
Now queued up, thanks.
greg k-h
