On Wed, Oct 4, 2023 at 5:52 PM Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > > > > On 10/4/2023 1:19 PM, Namhyung Kim wrote: > > Hello, > > > > On Wed, Oct 4, 2023 at 12:33 PM Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > >> > >> +Namhyung, Ian, > >> > >> On 10/4/23 10:52, Greg Kroah-Hartman wrote: > >>> This is the start of the stable review cycle for the 6.1.56 release. > >>> There are 259 patches in this series, all will be posted as a response > >>> to this one. If anyone has any issues with these being applied, please > >>> let me know. > >>> > >>> Responses should be made by Fri, 06 Oct 2023 17:51:12 +0000. > >>> Anything received after that time might be too late. > >>> > >>> The whole patch series can be found in one patch at: > >>> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.56-rc1.gz > >>> or in the git tree and branch at: > >>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y > >>> and the diffstat can be found below. > >>> > >>> thanks, > >>> > >>> greg k-h > >> > >> perf fails to build with: > >> > >> fixdep: error opening depfile: > >> /local/users/fainelli/buildroot/output/arm/build/linux-custom/tools/perf/pmu-events/.pmu-events.o.d: > >> No such file or directory > >> make[5]: *** [pmu-events/Build:33: > >> /local/users/fainelli/buildroot/output/arm/build/linux-custom/tools/perf/pmu-events/pmu-events.o] > >> Error 2 > >> make[4]: *** [Makefile.perf:672: > >> /local/users/fainelli/buildroot/output/arm/build/linux-custom/tools/perf/pmu-events/pmu-events-in.o] > >> Error 2 > >> make[3]: *** [Makefile.perf:240: sub-make] Error 2 > >> make[2]: *** [Makefile:70: all] Error 2 > >> make[1]: *** [package/pkg-generic.mk:294: > >> /local/users/fainelli/buildroot/output/arm/build/linux-tools/.stamp_built] > >> Error 2 > >> make: *** [Makefile:27: _all] Error 2 > >> > >> due a80fd00cb1a7793ead4d7c3fa7d3f1e898231c27 ("perf build: Update build > >> rule for generated files"). Reverting that commit fixes the build for me > >> and then all is good in terms of testing. > > > > I think it's ok to drop the patches if it's not applied > > cleanly. > > AFAICT the patch applied cleanly. There was some bizarre interplay in > stable kernels prior to < 6.1 as reported here: > > https://lore.kernel.org/all/dcb9997a-2e8a-5eb2-7a34-f8af418d4bf1@xxxxxxxxx/ > https://lore.kernel.org/all/6a577578-8adb-aa70-1bf8-b1a4573152cf@xxxxxxxxx/ > > Does this make sense to you that on 6.1 which does have Ian's commit > 00facc760903be6675870c2749e2cd72140e396e ("perf jevents: Switch build to > use jevents.py") that we would still get this build error somehow? You can drop the pmu-events part of the change if possible. If not, I'm ok to drop the entire patch as it's intended to fix a corner case only. Normal builds should be fine before and after the change. Thanks, Namhyung