Re: [PATCH 6.5 158/211] ata: libata: remove references to non-existing error_handler()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 2023/09/20 5:38, Niklas Cassel wrote:
> On Wed, Sep 20, 2023 at 01:30:02PM +0200, Greg Kroah-Hartman wrote:
>> 6.5-stable review patch.  If anyone has any objections, please let me know.
> Hello Greg,
> I don't think that we should backport this commit.

Yes, we should not. The IPR driver is still in stable, so adding this patch
would be wrong.

> While the patch did apply without conflicts, it was part of a series that
> did a bunch of other cleanups as well.
> I think that it is best to either have that whole series (and we don't want
> to backport the whole series), or none of the patches in that series.
> (So that at least we know that we have one or the other, not some half-way
> cleanup that will only live in v6.5 stable.)
>> ------------------
>> From: Hannes Reinecke <hare@xxxxxxx>
>> [ Upstream commit ff8072d589dcff7c1f0345a6ec98b5fc1e9ee2a1 ]
>> With commit 65a15d6560df ("scsi: ipr: Remove SATA support") all
>> libata drivers now have the error_handler() callback provided,
>> so we can stop checking for non-existing error_handler callback.
>> Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
>> [niklas: fixed review comments, rebased, solved conflicts during rebase,
>> fixed bug that unconditionally dumped all QCs, removed the now unused
>> function ata_dump_status(), removed the now unreachable failure paths in
>> atapi_qc_complete(), removed the non-EH function to request ATAPI sense]
>> Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxx>
>> Reviewed-by: John Garry <john.g.garry@xxxxxxxxxx>
>> Reviewed-by: Jason Yan <yanaijie@xxxxxxxxxx>
>> Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
>> Signed-off-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
>> Stable-dep-of: 5e35a9ac3fe3 ("ata: libata-core: fetch sense data for successful commands iff CDL enabled")
> Yes, it is true that
> 5e35a9ac3fe3 ("ata: libata-core: fetch sense data for successful commands iff CDL enabled")
> does not apply cleanly to v6.5 stable without this big commit.
> I'm attaching a backported version of that patch (which is only 2 lines or so)
> that can be applied to v6.5 stable instead.
> Kind regards,
> Niklas

Damien Le Moal
Western Digital Research

[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux