On Mon, Nov 10, 2014 at 08:59:08AM -0600, Felipe Balbi wrote: > From: Robert Baldyga <r.baldyga@xxxxxxxxxxx> > > [ Upstream commit a3058a5d82e296daaca07411c3738a9ddd79f302 ] > > During FunctionFS bind, ffs_data_get() function was called twice > (in functionfs_bind() and in ffs_do_functionfs_bind()), while on unbind > ffs_data_put() was called once (in functionfs_unbind() function). > In result refcount never reached value 0, and ffs memory resources has > been never released. > > Since ffs_data_get() call in ffs_do_functionfs_bind() is redundant > and not neccessary, we remove it to have equal number of gets ans puts, > and free allocated memory after refcount reach 0. > > Fixes: 5920cda (usb: gadget: FunctionFS: convert to new function > interface with backward compatibility) > Cc: <stable@xxxxxxxxxxxxxxx> # v3.14+ > Signed-off-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx> > Signed-off-by: Felipe Balbi <balbi@xxxxxx> please ignore this one too. -- balbi
Attachment:
signature.asc
Description: Digital signature