On Mon, Sep 18, 2023 at 04:48:31PM -0400, Alex Deucher wrote: > From: Christian König <christian.koenig@xxxxxxx> > > The offset is just 32bits here so this can potentially overflow if > somebody specifies a large value. Instead reduce the size to calculate > the last possible offset. > > The error handling path incorrectly drops the reference to the user > fence BO resulting in potential reference count underflow. > > Signed-off-by: Christian König <christian.koenig@xxxxxxx> > Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx> > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx > (cherry picked from commit 35588314e963938dfdcdb792c9170108399377d6) > --- > > This is a backport of 35588314e963 ("drm/amdgpu: fix amdgpu_cs_p1_user_fence") > to 6.5 and older stable kernels because the original patch does not apply > cleanly as is. > > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 18 ++++-------------- > 1 file changed, 4 insertions(+), 14 deletions(-) Now queued up, thanks. greg k-h