On Tue, Sep 19, 2023 at 09:06:54AM -0400, Sasha Levin wrote: > On Tue, Sep 19, 2023 at 08:15:04AM +0200, Johan Hovold wrote: > >On Mon, Sep 18, 2023 at 05:41:38PM -0400, Sasha Levin wrote: > >> On Mon, Sep 11, 2023 at 08:33:02AM +0200, Johan Hovold wrote: > >> >On Fri, Sep 08, 2023 at 03:28:41PM -0400, Sasha Levin wrote: > >> >> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> > >> >> > >> >> [ Upstream commit 1c63dd1c5fdafa8854526d7d60d2b741c813678d ] > >> >> > >> >> Disappointigly, the camera activity LED is implemented in software. > >> >> Hook it up as a gpio-led and (until we have camera *and* a "camera on" > >> >> LED trigger) configure it as a panic indicator. > >> >> > >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> > >> >> Link: https://lore.kernel.org/r/20230805-topic-x13s_cam_led-v1-1-443d752158c4@xxxxxxxxxx > >> >> Signed-off-by: Bjorn Andersson <andersson@xxxxxxxxxx> > >> >> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> > >> > > >> >This is a new feature if anything, not a fix. Please drop from all > >> >autosel queues. > >> > >> Not a feature, but hardware enablement. > > > >Call it what you will, but please drop it. Otherwise by that logic you'd > >need to backport all devicetree patches (as well as most driver changes) > >since they ultimately aim at enabling hardware. > > Not all, only ones that re-use existing kernel driver but enable it for > new hardware (i.e. adding a new pci-id/usb-id/dts entries). Again, that's basically all our device-tree patches. And that can break in all sorts of ways. So again, please drop. This does not belong in stable. Johan
