This is a note to let you know that I've just added the patch titled quota: Properly return errors from dquot_writeback_dquots() to the 3.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: quota-properly-return-errors-from-dquot_writeback_dquots.patch and it can be found in the queue-3.10 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 474d2605d119479e5aa050f738632e63589d4bb5 Mon Sep 17 00:00:00 2001 From: Jan Kara <jack@xxxxxxx> Date: Wed, 22 Oct 2014 09:06:49 +0200 Subject: quota: Properly return errors from dquot_writeback_dquots() From: Jan Kara <jack@xxxxxxx> commit 474d2605d119479e5aa050f738632e63589d4bb5 upstream. Due to a switched left and right side of an assignment, dquot_writeback_dquots() never returned error. This could result in errors during quota writeback to not be reported to userspace properly. Fix it. Coverity-id: 1226884 Signed-off-by: Jan Kara <jack@xxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- fs/quota/dquot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/quota/dquot.c +++ b/fs/quota/dquot.c @@ -637,7 +637,7 @@ int dquot_writeback_dquots(struct super_ dqstats_inc(DQST_LOOKUPS); err = sb->dq_op->write_dquot(dquot); if (!ret && err) - err = ret; + ret = err; dqput(dquot); spin_lock(&dq_list_lock); } Patches currently in stable-queue which might be from jack@xxxxxxx are queue-3.10/ext3-don-t-check-quota-format-when-there-are-no-quota-files.patch queue-3.10/evm-check-xattr-value-length-and-type-in-evm_inode_setxattr.patch queue-3.10/scsi-fix-error-handling-in-scsi_ioctl_send_command.patch queue-3.10/ext4-don-t-check-quota-format-when-there-are-no-quota-files.patch queue-3.10/lib-bitmap.c-fix-undefined-shift-in-__bitmap_shift_-left-right.patch queue-3.10/ext4-fix-oops-when-loading-block-bitmap-failed.patch queue-3.10/vfs-fix-data-corruption-when-blocksize-pagesize-for-mmaped-data.patch queue-3.10/ext4-fix-overflow-when-updating-superblock-backups-after-resize.patch queue-3.10/ext4-grab-missed-write_count-for-ext4_ioc_swap_boot.patch queue-3.10/quota-properly-return-errors-from-dquot_writeback_dquots.patch -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html