Patch "USB: kobil_sct: fix non-atomic allocation in write path" has been added to the 3.14-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    USB: kobil_sct: fix non-atomic allocation in write path

to the 3.14-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     usb-kobil_sct-fix-non-atomic-allocation-in-write-path.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.


>From 191252837626fca0de694c18bb2aa64c118eda89 Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan@xxxxxxxxxx>
Date: Wed, 29 Oct 2014 09:07:30 +0100
Subject: USB: kobil_sct: fix non-atomic allocation in write path

From: Johan Hovold <johan@xxxxxxxxxx>

commit 191252837626fca0de694c18bb2aa64c118eda89 upstream.

Write may be called from interrupt context so make sure to use
GFP_ATOMIC for all allocations in write.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
 drivers/usb/serial/kobil_sct.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

--- a/drivers/usb/serial/kobil_sct.c
+++ b/drivers/usb/serial/kobil_sct.c
@@ -335,7 +335,8 @@ static int kobil_write(struct tty_struct
 			port->interrupt_out_urb->transfer_buffer_length = length;
 
 			priv->cur_pos = priv->cur_pos + length;
-			result = usb_submit_urb(port->interrupt_out_urb, GFP_NOIO);
+			result = usb_submit_urb(port->interrupt_out_urb,
+					GFP_ATOMIC);
 			dev_dbg(&port->dev, "%s - Send write URB returns: %i\n", __func__, result);
 			todo = priv->filled - priv->cur_pos;
 
@@ -350,7 +351,7 @@ static int kobil_write(struct tty_struct
 		if (priv->device_type == KOBIL_ADAPTER_B_PRODUCT_ID ||
 			priv->device_type == KOBIL_ADAPTER_K_PRODUCT_ID) {
 			result = usb_submit_urb(port->interrupt_in_urb,
-								GFP_NOIO);
+					GFP_ATOMIC);
 			dev_dbg(&port->dev, "%s - Send read URB returns: %i\n", __func__, result);
 		}
 	}


Patches currently in stable-queue which might be from johan@xxxxxxxxxx are

queue-3.14/usb-option-add-haier-ce81b-cdma-modem.patch
queue-3.14/usb-opticon-fix-non-atomic-allocation-in-write-path.patch
queue-3.14/usb-kobil_sct-fix-non-atomic-allocation-in-write-path.patch
queue-3.14/hid-usbhid-add-always-poll-quirk.patch
queue-3.14/usb-cdc-acm-add-device-id-for-gw-instek-afg-2225.patch
queue-3.14/hid-usbhid-enable-always-poll-quirk-for-elan-touchscreen.patch
queue-3.14/usb-option-add-support-for-telit-le910.patch
queue-3.14/usb-core-add-device-qualifier-quirk.patch
queue-3.14/usb-quirks-enable-device-qualifier-quirk-for-elan-touchscreen.patch
queue-3.14/usb-serial-ftdi_sio-add-awinda-station-and-dongle-products.patch
queue-3.14/usb-serial-cp210x-add-silicon-labs-358x-vid-and-pid.patch
queue-3.14/usb-cdc-acm-only-raise-dtr-on-transitions-from-b0.patch
queue-3.14/usb-serial-ftdi_sio-add-bricked-ftdi-device-pid.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]