Re: [PATCHv2] nvme: avoid bogus CRTO values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/14/23 22:58, Keith Busch wrote:
On Thu, Sep 14, 2023 at 10:48:55PM +0300, Felix Yan wrote:

Thanks, verified that it works well here.

Thanks, okay if I append your Tested-by: in the patch?

Sure :)

I noticed only one very small issue: dev_warn_once seems to only print once
when multiple devices are affected. It may be more ideal if it prints once
for each device, but I don't know how to really achieve that...

There's no good way to do that, unfortunately. We'd have to create a
custom "print once" based on some driver specific flag for this path,
but that's overkill for this issue, IMO. I feel it should be sufficient
just to know that the fallback is happening, and doesn't really matter
for an admin scanning the logs to see it appear for each device. My main
concern was printing it on every reset; that level of repitition would
definitely cause alarm for some people.

I see. I'm okay with the current solution then.

--
Regards,
Felix Yan

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux