Re: [PATCH v2 1/2] maple_tree: Disable mas_wr_append() when other readers are possible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Le 12/09/2023 à 17:44, Liam R. Howlett a écrit :
> diff --git a/init/main.c b/init/main.c
> index dbe1fe76be34..fd4739918a94 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -696,7 +696,7 @@ noinline void __ref __noreturn rest_init(void)
>   	 */
>   	rcu_read_lock();
>   	tsk = find_task_by_pid_ns(pid, &init_pid_ns);
> -	tsk->flags |= PF_NO_SETAFFINITY;
> +	tsk->flags |= PF_NO_SETAFFINITY & PF_IDLE;

Is it really what you want to do ?

PF_NO_SETAFFINITY is 0x04000000 and PF_IDLE is 0x00000002 so

PF_NO_SETAFFINITY & PF_IDLE is 0


Didn't you mean to do PF_NO_SETAFFINITY | PF_IDLE  ?


Regardless, with either change I don't get the warning anymore.



>   	set_cpus_allowed_ptr(tsk, cpumask_of(smp_processor_id()));
>   	rcu_read_unlock();
>   
> @@ -943,6 +943,7 @@ void start_kernel(void)
>   	 * time - but meanwhile we still have a functioning scheduler.
>   	 */
>   	sched_init();
> +	current->flags &= ~PF_IDLE;
>   
>   	if (WARN(!irqs_disabled(),
>   		 "Interrupts were enabled *very* early, fixing it\n"))
> 




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux