On Mon, Sep 11, 2023 at 03:33:01PM +0100, Mark Brown wrote:
> On Mon, Sep 11, 2023 at 03:38:53PM +0200, Greg Kroah-Hartman wrote:
> > 6.5-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Alexander Danilenko <al.b.danilenko@xxxxxxxxx>
> >
> > [ Upstream commit 373c36bf7914e3198ac2654dede499f340c52950 ]
> >
> > cs_setup, cs_hold and cs_inactive points to fields of spi_device struct,
> > so there is no sense in checking them for NULL.
> >
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> This is a code cleanup, why is it a stable candidate? It's not a
> warning fix or anything.
{sigh} This is due to the crazy people using SVACE marking stuff as a
"fix" when it really isn't to try to boost the chance that their patches
will be accepted :(
I'm all but refusing to take their patches now due to all of the
problems they have caused in the past. I'll go drop this from all
stable queues as well, thanks for catching this.
greg k-h
