On 9/9/23 3:38 AM, Sasha Levin wrote: > From: Ma Ke <make_ruc2021@xxxxxxx> > > [ Upstream commit ce9daa2efc0872a9a68ea51dc8000df05893ef2e ] > > We should verify the bound of the array to assure that host > may not manipulate the index to point past endpoint array. > > Signed-off-by: Ma Ke <make_ruc2021@xxxxxxx> > Acked-by: Li Yang <leoyang.li@xxxxxxx> > Link: https://lore.kernel.org/r/20230628081511.186850-1-make_ruc2021@xxxxxxx > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> > --- > drivers/usb/gadget/udc/fsl_qe_udc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c b/drivers/usb/gadget/udc/fsl_qe_udc.c > index 15db7a3868fe4..aff4050f96dd6 100644 > --- a/drivers/usb/gadget/udc/fsl_qe_udc.c > +++ b/drivers/usb/gadget/udc/fsl_qe_udc.c > @@ -1956,6 +1956,8 @@ static void ch9getstatus(struct qe_udc *udc, u8 request_type, u16 value, > } else if ((request_type & USB_RECIP_MASK) == USB_RECIP_ENDPOINT) { > /* Get endpoint status */ > int pipe = index & USB_ENDPOINT_NUMBER_MASK; > + if (pipe >= USB_MAX_ENDPOINTS) > + goto stall; Hm, what's the earliest version of gcc needed to compile this (*if* statement amongst the variable declarations)? > struct qe_ep *target_ep = &udc->eps[pipe]; > u16 usep; > MBR, Sergey
