Hi Greg,
Seems this needs to been backported too:
https://github.com/torvalds/linux/commit/8e6c00f1fdea9fdf727969d7485d417240d2a1f9
At least an #include "../../codecs/rt711.h" in
sound/soc/intel/boards/sof_sdw.c
On 28.08.23 07:09, Philip Müller wrote:
Hi Greg,
I applied that patch on top of 5.10.192 however I get still the same error:
2023-08-27T20:53:30.8714926Z -> Applying patch:
asoc-rt711-add-two-jack-detection-modes.patch...
2023-08-27T20:53:30.8725584Z patching file sound/soc/codecs/rt711-sdw.h
2023-08-27T20:53:30.8727337Z patching file sound/soc/codecs/rt711.c
2023-08-27T20:53:30.8729516Z patching file sound/soc/codecs/rt711.h
...
2023-08-27T21:15:14.5273400Z CC [M] sound/soc/intel/boards/sof_sdw.o
2023-08-27T21:15:15.1639214Z sound/soc/intel/boards/sof_sdw.c:208:41:
error: ‘RT711_JD2_100K’ undeclared here (not in a function)
2023-08-27T21:15:15.1640795Z 208 | .driver_data =
(void *)(RT711_JD2_100K),
2023-08-27T21:15:15.1641904Z | ^~~~~~~~~~~~~~
2023-08-27T21:15:15.2094047Z make[4]: *** [scripts/Makefile.build:286:
sound/soc/intel/boards/sof_sdw.o] Error 1
2023-08-27T21:15:15.2105479Z make[3]: *** [scripts/Makefile.build:503:
sound/soc/intel/boards] Error 2
2023-08-27T21:15:15.2107050Z make[2]: *** [scripts/Makefile.build:503:
sound/soc/intel] Error 2
2023-08-27T21:15:15.2154855Z make[1]: *** [scripts/Makefile.build:503:
sound/soc] Error 2
2023-08-27T21:15:15.2155979Z make: *** [Makefile:1832: sound] Error 2
Is there another patch, change you may have missed?
On 27.08.23 20:29, Greg Kroah-Hartman wrote:
On Sat, Aug 26, 2023 at 10:36:41PM +0200, Philip Müller wrote:
Hi Greg,
please revert the following two patches as 5.10.192 fails to build with
them:
asoc-intel-sof_sdw-add-quirk-for-lnl-rvp.patch
asoc-intel-sof_sdw-add-quirk-for-mtl-rvp.patch
Error message: error: ‘RT711_JD2_100K’ undeclared here (not in a
function)
2023-08-26T17:46:51.3733116Z sound/soc/intel/boards/sof_sdw.c:208:41:
error:
‘RT711_JD2_100K’ undeclared here (not in a function)
2023-08-26T17:46:51.3744338Z 208 | .driver_data =
(void
*)(RT711_JD2_100K),
2023-08-26T17:46:51.3745547Z | ^~~~~~~~~~~~~~
2023-08-26T17:46:51.4620173Z make[4]: *** [scripts/Makefile.build:286:
sound/soc/intel/boards/sof_sdw.o] Error 1
2023-08-26T17:46:51.4625055Z make[3]: *** [scripts/Makefile.build:503:
sound/soc/intel/boards] Error 2
2023-08-26T17:46:51.4626370Z make[2]: *** [scripts/Makefile.build:503:
sound/soc/intel] Error 2
This happened before already:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/commit/queue-5.10?id=2e4795b45723de3d253f38bc57724d9512c737f5
{sigh} Sorry about that.
I just backported commit 683b0df26c33 ("ASoC: rt711: add two jack
detection modes") instead, that should solve this issue and give more
support to that kernel tree if anyone is actually using it there (based
on me not geting any build errors from any CI systems for that driver, I
kind of doubt it...)
thanks,
greg k-h
--
Best, Philip
