Re: [PATCH 6.1.y 0/2] Address ltp nfs test failure.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello!

On Fri, 25 Aug 2023 at 10:17, Harshit Mogalapalli
<harshit.m.mogalapalli@xxxxxxxxxx> wrote:
> These two are backports for 6.1.y. Conflict resolution in done in
> both patches.
> I have tested LTP-nfs fchown02 and chown02 on 6.1.y with below patches
> applied. The tests passed.

I have given this a go but did not see better results.

On 6.1.48-rc1, without any extra patches:
  https://lkft.validation.linaro.org/scheduler/job/6685964#L3814
  https://storage.tuxsuite.com/public/linaro/lkft/builds/2UR2OCpseRQ0lu76phKZBw6l2xf/

On 6.1.48-rc1 plus this series of patches:
  https://lkft.validation.linaro.org/scheduler/job/6692637#L3832
  https://lkft.validation.linaro.org/scheduler/job/6692642#L3818
  https://storage.tuxsuite.com/public/linaro/daniel/builds/2UUHtMsTAQeuei3gGM32NWZx82w/

In both cases:
  chown02.c:46: TPASS: chown(testfile1, 0, 0) passed
  chown02.c:46: TPASS: chown(testfile2, 0, 0) passed
  chown02.c:58: TFAIL: testfile2: wrong mode permissions 0100700,
expected 0102700
[...]
  fchown02.c:57: TPASS: fchown(3, 0, 0) passed
  fchown02.c:57: TPASS: fchown(4, 0, 0) passed
  fchown02.c:67: TFAIL: testfile2: wrong mode permissions 0100700,
expected 0102700

The exact same thing happened with the 5.15 patch series.

I'll be glad to test more patches.

Greetings!

Daniel Díaz
daniel.diaz@xxxxxxxxxx


> I would like to have a review as I am not familiar with this code.
>
> Thanks to Vegard for helping me with this.
>
> Thanks,
> Harshit
>
> Christian Brauner (2):
>   nfs: use vfs setgid helper
>   nfsd: use vfs setgid helper
>
>  fs/attr.c          | 1 +
>  fs/internal.h      | 2 --
>  fs/nfs/inode.c     | 4 +---
>  fs/nfsd/vfs.c      | 4 +++-
>  include/linux/fs.h | 2 ++
>  5 files changed, 7 insertions(+), 6 deletions(-)
>
> --
> 2.34.1
>




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux