Re: [PATCH dlm/next] dlm: fix plock lookup when using multiple lockspaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Aug 24, 2023 at 7:22 PM Alexander Aring <aahringo@xxxxxxxxxx> wrote:
...
>
> The reason why I probably never saw it is because those fields in my
> tests are always the same and we simply don't compare all fields on
> the sanity check.

I need to correct some things here... the patch works, but the commit
message related to some locking issues is wrong. It works to make the
lookup on a per lockspace basis because dlm_controld has a per
lockspace corosync handle. Corosync keeps plock_op and results in
order which is necessary for the lookup mechanism here. So this
mechanism is on a per lockspace basis in order, if dlm_controld would
have a global corosync handle it would work on a global basis.

The issue I saw with putting more sanity checks for start/end fields
does not work because DLM_PLOCK_OP_GET will manipulate fields and they
can't be compared between original request and result. I ran into this
issue a couple times...

- Alex





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux