Re: [PATCH 6.4 173/234] sfc: add fallback action-set-lists for TC offload

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21/08/2023 20:42, Greg Kroah-Hartman wrote:
> From: Edward Cree <ecree.xilinx@xxxxxxxxx>
> 
> [ Upstream commit e16ca7fb9ffb0d51ddf01e450a1043ea65b5be3f ]
> 
> When offloading a TC encap action, the action information for the
>  hardware might not be "ready": if there's currently no neighbour entry
>  available for the destination address, we can't construct the Ethernet
>  header to prepend to the packet.  In this case, we still offload the
>  flow rule, but with its action-set-list ID pointing at a "fallback"
>  action which simply delivers the packet to its default destination (as
>  though no flow rule had matched), thus allowing software TC to handle
>  it.  Later, when we receive a neighbouring update that allows us to
>  construct the encap header, the rule will become "ready" and we will
>  update its action-set-list ID in hardware to point at the actual
>  offloaded actions.
> This patch sets up these fallback ASLs, but does not yet use them.
> 
> Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@xxxxxxx>
> Signed-off-by: Edward Cree <ecree.xilinx@xxxxxxxxx>
> Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> Stable-dep-of: fa165e194997 ("sfc: don't unregister flow_indr if it was never registered")

I don't think this is actually needed by that commit; it's textually
 part of the context but not semantically important to it.
Why can't you do the same thing you did for 6.1?
-ed

> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux