On Mon, Aug 21, 2023 at 02:54:10PM -0700, Florian Fainelli wrote: > From: Justin Chen <justin.chen@xxxxxxxxxxxx> > > commit 096516d092d54604d590827d05b1022c8f326639 upstream > > The 54810 does not support c45. The mmd_phy_indirect accesses return > arbirtary values leading to odd behavior like saying it supports EEE > when it doesn't. We also see that reading/writing these non-existent > MMD registers leads to phy instability in some cases. > > Fixes: b14995ac2527 ("net: phy: broadcom: Add BCM54810 PHY entry") > Signed-off-by: Justin Chen <justin.chen@xxxxxxxxxxxx> > Reviewed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx> > Link: https://lore.kernel.org/r/1691901708-28650-1-git-send-email-justin.chen@xxxxxxxxxxxx > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> > [florian: resolved conflicts in 4.14] > Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx> Thanks for these, all now queued up. greg k-h