On Mon, Aug 21, 2023 at 07:59:18PM +0200, Karol Herbst wrote: > We can't simply free the connector after calling drm_connector_init on it. > We need to clean up the drm side first. > > It might not fix all regressions from commit 2b5d1c29f6c4 > ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts"), > but at least it fixes a memory corruption in error handling related to > that commit. > > Link: https://lore.kernel.org/lkml/20230806213107.GFZNARG6moWpFuSJ9W@fat_crate.local/ > Fixes: 95983aea8003 ("drm/nouveau/disp: add connector class") > Signed-off-by: Karol Herbst <kherbst@xxxxxxxxxx> > Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx> > Link: https://patchwork.freedesktop.org/patch/msgid/20230814144933.3956959-1-kherbst@xxxxxxxxxx > (cherry picked from commit 1b254b791d7b7dea6e8adc887fbbd51746d8bb27) > Signed-off-by: Karol Herbst <kherbst@xxxxxxxxxx> > --- > drivers/gpu/drm/nouveau/nouveau_connector.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Now queued up, thanks. greg k-h