Re: [PATCH 1/2] drm/amd/pm: skip the RLC stop when S0i3 suspend for SMU v13.0.4/11

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 8/17/2023 8:40 AM, Alex Deucher wrote:
From: Tim Huang <Tim.Huang@xxxxxxx>

For SMU v13.0.4/11, driver does not need to stop RLC for S0i3,
the firmwares will handle that properly.

Signed-off-by: Tim Huang <Tim.Huang@xxxxxxx>
Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxx>
Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
(cherry picked from commit 730d44e1fa306a20746ad4a85da550662aed9daa)
Cc: stable@xxxxxxxxxxxxxxx # 6.1.x

Greg,

Just want to make sure this one didn't get accidentally skipped since you populated the stable queues and didn't see it landed.

Thanks!

---
  drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
index ea03e8d9a3f6..818379276a58 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
@@ -1573,9 +1573,9 @@ static int smu_disable_dpms(struct smu_context *smu)
/*
  	 * For SMU 13.0.4/11, PMFW will handle the features disablement properly
-	 * for gpu reset case. Driver involvement is unnecessary.
+	 * for gpu reset and S0i3 cases. Driver involvement is unnecessary.
  	 */
-	if (amdgpu_in_reset(adev)) {
+	if (amdgpu_in_reset(adev) || adev->in_s0ix) {
  		switch (adev->ip_versions[MP1_HWIP][0]) {
  		case IP_VERSION(13, 0, 4):
  		case IP_VERSION(13, 0, 11):



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux