Hi Greg,
To clarify the kernel test robot report:
[stable:linux-6.1.y 7217/8698] security/integrity/evm/evm_main.c:788:
warning: Excess function parameter 'idmap' description in
'evm_inode_setattr'
Commit b1de86d4248b added two missing kernel-doc function arguments.
Both changes should be backported to 6.3, but then only "* @attr: iattr
structure containing the new file attributes" should be backported.
thanks,
Mimi
On Sun, 2023-07-16 at 21:43 +0200, Greg Kroah-Hartman wrote:
> From: Roberto Sassu <roberto.sassu@xxxxxxxxxx>
>
> [ Upstream commit b1de86d4248b273cb12c4cd7d20c08d459519f7d ]
>
> Add the description for missing parameters of evm_inode_setattr() to
> avoid the warning arising with W=n compile option.
>
> Fixes: 817b54aa45db ("evm: add evm_inode_setattr to prevent updating an invalid security.evm") # v3.2+
> Fixes: c1632a0f1120 ("fs: port ->setattr() to pass mnt_idmap") # v6.3+
> Signed-off-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx>
> Reviewed-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>
> Signed-off-by: Mimi Zohar <zohar@xxxxxxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> ---
> security/integrity/evm/evm_main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/security/integrity/evm/evm_main.c b/security/integrity/evm/evm_main.c
> index 23d484e05e6f2..f1a26d50c1d58 100644
> --- a/security/integrity/evm/evm_main.c
> +++ b/security/integrity/evm/evm_main.c
> @@ -776,7 +776,9 @@ static int evm_attr_change(struct user_namespace *mnt_userns,
>
> /**
> * evm_inode_setattr - prevent updating an invalid EVM extended attribute
> + * @idmap: idmap of the mount
> * @dentry: pointer to the affected dentry
> + * @attr: iattr structure containing the new file attributes
> *
> * Permit update of file attributes when files have a valid EVM signature,
> * except in the case of them having an immutable portable signature.
