Re: [PATCH v2 1/2] tpm/tpm_tis: Disable interrupts for Framework Laptop Intel 12th gen

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri Aug 11, 2023 at 1:44 PM EEST, Grundik wrote:
> On Fri, 2023-08-11 at 10:18 +0200, Thorsten Leemhuis wrote:
> > Jarkko & Lino, did you see this msg Grundik posted that about a week
> > ago? It looks like there is still something wrong there that need
> > attention. Or am I missing something?
> > 
> > FWIW, two more users reported that they still see similar problems
> > with
> > recent 6.4.y kernels that contain the "tpm,tpm_tis: Disable
> > interrupts
> > after 1000 unhandled IRQs" patch. Both also with MSI laptops:
> > 
> > https://bugzilla.kernel.org/show_bug.cgi?id=217631#c18
> > https://bugzilla.kernel.org/show_bug.cgi?id=217631#c20
> > 
> > No reply either afaics.
>
> As I said before: it does not looks like blacklisting is a good
> solution at all.
>
> If there are general fix, then blacklisting only makes testing of that
> fix more difficult. If general fix works, why blacklist? If it does not
> work and its impossible to figure out why — maybe there should be
> kernel boot option to select between polling/irq instead of/in addition
> to hard-coded blacklist.
>
> Unfortunately, its very hard to test this fixes on my side: since TPM
> is not a module, but compiled into kernel itself, it requires
> recompiling a whole kernel, which is quite a task for a laptop. But I
> will try my best, if needed.

I agree with this.

Can you check my response to Thorsten and share your opinions?

BR, Jarkko




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux