On Wed, Aug 9, 2023 at 3:48 PM Mighty <bavishimithil@xxxxxxxxx> wrote: > > The current code "mostly works" because we have not run into > > systems supporting only raw but not scale or only scale but not > > raw, and I doubt there are few using the rescaler on anything > > such, but let's fix the logic. > > This does break the logic for twl6030/6032 boards as the seem to > only have only raw and processed masks[1]. What would a probable > solution for it be, to modify the twl gpadc to include scale+raw or just > revert back to the OR? > > [1] https://github.com/torvalds/linux/blob/master/drivers/iio/adc/twl6030-gpadc.c#L808-L840 How does it break it? It's a change to the AFE rescaler driver so it can't really "break" twl6030-gpadc. Isn't the complete picture involving some device tree using the prescaler etc? Can you try to dig out that so we can see the whole situation? Yours, Linus Walleij
