On Wed, Aug 9, 2023 at 9:20 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> Hi,
>
> On 8/9/23 17:58, August Wikerfors wrote:
> > On 2023-08-09 10:55, Hans de Goede wrote:
> >> On AMD Zen acpi_dev_irq_override() by default prefers the DSDT IRQ 1
> >> settings over the MADT settings.
> >>
> >> This causes the keyboard to malfunction on some laptop models
> >> (see Links), all models from the Links have an INT_SRC_OVR MADT entry
> >> for IRQ 1.
> >>
> >> Fixes: a9c4a912b7dc ("ACPI: resource: Remove "Zen" specific match and quirks")
> >> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217336
> >> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217394
> >> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217406
> >> Cc: Mario Limonciello <mario.limonciello@xxxxxxx>
> >> Cc: Linux regressions mailing list <regressions@xxxxxxxxxxxxxxx>
> >> Cc: stable@xxxxxxxxxxxxxxx
> >> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> >
> > One of the laptops fixed by a9c4a912b7dc, PCSpecialist Elimina Pro 16 M [1], seems to have no INT_SRC_OVR entry for IRQ 1 [2]:
> >
> >> [ 0.084265] ACPI: INT_SRC_OVR (bus 0 bus_irq 0 global_irq 2 dfl dfl)
> >> [ 0.084266] ACPI: INT_SRC_OVR (bus 0 bus_irq 9 global_irq 9 low level)
> >
> > I'm not sure if it was IRQ 1 that needed to be overridden for that model though, so it may work anyway with patch 2 of this series.
> >
> > [1] https://bugzilla.kernel.org/show_bug.cgi?id=217394#c18
> > [2] https://bugzilla.kernel.org/attachment.cgi?id=304338
>
> Good catch, thanks. So it looks like this one needs a DMI quirk (until we have a better generic solution.
>
> I'll reach out to the reporter and ask for dmidecode output and prepare a follow-up patch. Still I think
> that we should move forward with this series to fix the 6 bugs which are linked to from PAtch 1's
> commitmsg and those are likely just the top of the iceberg.
You are probably right, but it would be good to get a fix for this
ASAP, as I would prefer it to go in along with the series, if
possible.
